Fix things not working when there is a bind log #1695
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there is a
bind log
, a few things stop working, as they do not expect logging functions to change the Tcl interpreter result.This fixes those issues by storing the result before triggering the log binds and restoring it after the call.
Things found to be broken:
.tcl
dcc command (empty result is shown)And maybe a few more.
Found by: DasBrain
Patch by: DasBrain
Fixes: bind log, hopefully.
One-line summary:
Fix wrong Tcl results when there is a bind log.
Additional description (if needed):
Test cases demonstrating functionality (if applicable):
.tcl string cat foo
.tcl bind log * +|+ {string cat}
.tcl string cat foo