Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix things not working when there is a bind log #1695

Merged
merged 1 commit into from
Dec 1, 2024

Conversation

DasBrain
Copy link
Contributor

@DasBrain DasBrain commented Oct 7, 2024

When there is a bind log, a few things stop working, as they do not expect logging functions to change the Tcl interpreter result.

This fixes those issues by storing the result before triggering the log binds and restoring it after the call.

Things found to be broken:

  • .tcl dcc command (empty result is shown)
  • Tcl errors reported in bind.

And maybe a few more.

Found by: DasBrain
Patch by: DasBrain
Fixes: bind log, hopefully.

One-line summary:
Fix wrong Tcl results when there is a bind log.

Additional description (if needed):

Test cases demonstrating functionality (if applicable):
.tcl string cat foo
.tcl bind log * +|+ {string cat}
.tcl string cat foo

Copy link
Member

@thommey thommey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vanosg vanosg added this to the v1.10.1 milestone Dec 1, 2024
@vanosg vanosg merged commit 1e56584 into eggheads:develop Dec 1, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants