Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix .channel formatting #1679

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from

Conversation

michaelortmann
Copy link
Member

@michaelortmann michaelortmann commented Aug 21, 2024

Found by: vanosg
Patch by: michaelortmann
Fixes: #1672

One-line summary:
Fix .channel formatting

Additional description (if needed):

Test cases demonstrating functionality (if applicable):
1. .channel
Before:

Channel #test666, 2 members, mode +tn:
(n = owner, m = master, o = op, d = deop, b = bot)
 NICKNAME  HANDLE    ACCOUNT    JOIN   IDLE         USER@HOST
 BotA      *         *         05:20                <- it's me!
 testuser  testuser  *          ---   N             ~michael@localhost
End of channel info.

After:

Channel #test666, 2 members, mode +tn:
(n = owner, m = master, o = op, d = deop, b = bot)
 NICKNAME HANDLE   ACCOUNT JOIN   F IDLE         USER@HOST
 BotA     *        *       05:20                 ~BotA@localhost    <- it's me!
 testuser testuser *       *      N              ~michael@localhost
End of channel info.

2. .help channel:
Before:

[...]
      <D|Ares>  NICKNAME  HANDLE     JOIN  IDLE  USER@HOST
      <D|Ares> @Wcc       Wcc        ---  N      [email protected]
 
   The "@Wcc" means that the user's nickname is Wcc and that he is a chanop.
   The second "Wcc" is the user's handle. Sometimes this will differ from the
   nickname a person is using. The time displayed is the time the user joined
   the channel. The next field is the user's status flag. These are the same
   as the flags listed in .help whois. Global flags are uppercase. Only
   the 'highest' flag is displayed.
 
   The last two fields are the user's idle time, and the user@host they are
   connecting from
[...]

After:

[...]
       NICKNAME HANDLE ACCOUNT JOIN   F IDLE         USER@HOST
      @Wcc      Wcc    *       00:42  N              [email protected]
 
   The "@Wcc" means that the user's nickname is Wcc and that he is a chanop.
   The second "Wcc" is the user's handle. Sometimes this will differ from the
   nickname a person is using. The time displayed is the time the user joined
   the channel. The next field is the user's status flag. These are the same
   as the flags listed in .help whois. Global flags are uppercase. Only
   the 'highest' flag is displayed. The last two fields are the user's idle
   time (if more than 3 minutes), and the user@host they are connecting from.
 
   IDLE could display "(away)" as last away status known to the bot. It could
   be out of sync, if not tracked via away-notify capability or otherwise.
[...]

@vanosg vanosg mentioned this pull request Sep 8, 2024
@michaelortmann
Copy link
Member Author

Last commit resolved merge conflicts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.channel formatting needs correcting
1 participant