Fix user/chanrecord checking on join #1678
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found by: DasBrain
Patch by: Geo
One-line summary:
Fix user/chanrecord checking on join
Additional description (if needed):
As part of the account tracking additions, we didn't properly check flag records for a user joining a channel. Thanks to
lookup_user_record
, this patch now universally searches for a userrecord existing before creating the new channel record and eliminates the previous per-logic-branch checks. This functionality was unaffected in post-join events (mode changes, host changes, etc).Test cases demonstrating functionality (if applicable):
Before:
After:
Same for auto-op.
Also tested with a host-only user vs an account-only user, success in both cases.