Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert adding -fsanitize=address #1671

Merged
merged 1 commit into from
Aug 7, 2024
Merged

Conversation

michaelortmann
Copy link
Member

@michaelortmann michaelortmann commented Aug 2, 2024

Found by: michaelortmann
Patch by: michaelortmann
Fixes:

One-line summary:
Revert adding -fsanitize=address

Additional description (if needed):
Fix make bug, see test case below, introduced by #1644
So we can only add -Og, not -fsanitize=address
Due to the current ordering of eggdrop CFLAGS/DEBUGFLAGS, it is a good idea to remove it anyway, because currently -fsanitize=address is appended after USER CFLAGS.

Test cases demonstrating functionality (if applicable):

$ uname -a
Linux alpine320 6.6.33-0-lts #1-Alpine SMP PREEMPT_DYNAMIC Thu, 13 Jun 2024 07:49:22 +0000 x86_64 Linux
$ ./configure
[...]
checking whether C compiler accepts -fsanitize=address... yes
[...]
$ make
[...]
gcc -g -O2 -pipe -Wall -I.. -I..  -DHAVE_CONFIG_H -I/usr/include -Og -g3 -DDEBUG -fsanitize=address -DDEBUG_ASSERT -DDEBUG_MEM -DDEBUG_DNS -lpthread -o ../eggdrop bg.o botcmd.o botmsg.o botnet.o chanprog.o cmds.o dcc.o dccutil.o dns.o flags.o language.o match.o main.o mem.o misc.o misc_file.o modules.o net.o rfc1459.o tcl.o tcldcc.o tclhash.o tclmisc.o tcluser.o tls.o userent.o userrec.o users.o  -L/usr/lib -ltcl8.6  -lz -lpthread -lssl -lcrypto  md5/md5c.o compat/*.o `cat mod/mod.xlibs`
/usr/lib/gcc/x86_64-alpine-linux-musl/13.2.1/../../../../x86_64-alpine-linux-musl/bin/ld: cannot find libasan_preinit.o: No such file or directory
/usr/lib/gcc/x86_64-alpine-linux-musl/13.2.1/../../../../x86_64-alpine-linux-musl/bin/ld: cannot find -lasan: No such file or directory
collect2: error: ld returned 1 exit status
make[2]: *** [Makefile:48: link] Error 1
make[2]: Leaving directory '/home/michael/usr/src/eggdrop/src'
make[1]: *** [Makefile:57: ../eggdrop] Error 2
make[1]: Leaving directory '/home/michael/usr/src/eggdrop/src'
make: *** [Makefile:251: debug] Error 2

@vanosg vanosg merged commit cd91671 into eggheads:develop Aug 7, 2024
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants