Race fix: tdns: strerror() -> strerror_r() #1623
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found by: thommey and michaelortmann
Patch by: michaelortmann
Fixes:
One-line summary:
Fix locking / race for tdns error logging
Additional description (if needed):
Non main threads like tdns must use
strerror_r()
instead ofstrerror()
.Test cases demonstrating functionality (if applicable):
Without this patch applied, valgrind will report race