Update autobotchk #1584
Merged
Update autobotchk #1584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Apparently, with TCL 9, the `~` expansion ability was [removed](https://core.tcl-lang.org/tips/doc/trunk/tip/602.md). This PR should fix it. - Added the `-p` flag to the `mkdir` command, which stands for "parent" and it allows to create a directory hierarchy (a tree of directories) in one step, without getting an error if the parent directories already exist.
|
LGTM |
thommey
requested changes
Jul 27, 2024
Apparently, Tcl already creates the parent dirs as needed, so we can remove `-p`. Fix suggested by thommey Co-authored-by: Thomas Sader <[email protected]>
thommey
approved these changes
Jul 29, 2024
skralg
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found by: DasBrain
Patch by: TehPeGaSuS
Fixes: Fix tilde expansion removal on TCL 9
One-line summary:
Fix tilde expansion removal on TCL 9
Additional description (if needed):
~expansion ability was removed. This PR should fix it.-pflag to themkdircommand, which stands for "parent" and it allows to create a directory hierarchy (a tree of directories) in one step, without getting an error if the parent directories already exist or if they don't exist at all.Test cases demonstrating functionality (if applicable):