Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance auto detection of python-config #1562

Merged
merged 1 commit into from
May 5, 2024

Conversation

michaelortmann
Copy link
Member

Found by: michaelortmann
Patch by: michaelortmann
Fixes:

One-line summary:
Enhance auto detection of python-config

Additional description (if needed):
Operating systems like FreeBSD do not automatically have a symlink of python3-config or python-config, but only the direct python3.*-config
This PR doesnt make auto detection complete on my test system, but its a first step and certainly an enhancement of status quo
Please run misc/runautotools when merging this PR

Test cases demonstrating functionality (if applicable):
Before:

$ make config
[...]
Configuring module 'python'.
configure: loading cache ../../../config.cache
checking for grep that handles long lines and -e... /usr/bin/grep
checking for fgrep... /usr/bin/grep -F
checking whether to compile the Python module... autodetect
checking for python3-config... no
checking for python-config... no
configure: warning:

  Your system does not provide a working python-config binary.
  The python module will therefore be disabled.
[...]

After:

$ make config
[...]
Configuring module 'python'.
configure: loading cache ../../../config.cache
checking for grep that handles long lines and -e... /usr/bin/grep
checking for fgrep... /usr/bin/grep -F
checking for python3-config... no
checking for python-config... no
checking for python3.12-config... no
checking for python3.11-config... no
checking for python3.10-config... no
checking for python3.9-config... /usr/local/bin/python3.9-config
checking whether python-config supports --embed... yes
checking for python C flags... -I/usr/local/include/python3.9 -I/usr/local/include/python3.9  -Wno-unused-result -Wsign-compare -Wunreachable-code -O2 -pipe  -fstack-protector-strong -fno-strict-aliasing  -DNDEBUG 
checking for python LD flags...  -L/usr/local/lib -lpython3.9 -lcrypt -lintl -ldl -L/usr/local/lib -lintl -lutil -lm -lm 
checking for python... no
configure: WARNING: Cannot find python in your system path
.././python.mod/configure: -c: not found
checking for gawk... no
checking for mawk... no
checking for nawk... nawk
checking  version is >= 3.8.0... no ()
configure: WARNING: Eggdrop requires python version 3.8.0 or higher

  There was an issue with your python installation.
  Please read python.mod/config.log for more details.
  The python module will be disabled.
[...]

@vanosg vanosg added this to the v1.10.0 milestone May 5, 2024
@vanosg vanosg merged commit d7d3c0c into eggheads:develop May 5, 2024
2 checks passed
@michaelortmann michaelortmann deleted the python-config branch May 6, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants