Fix SERVER_NICKLEN off-by-one error #1549
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found by: michaelortmann
Patch by: michaelortmann
Fixes:
One-line summary:
Fix SERVER_NICKLEN off-by-one error
Additional description (if needed):
eggdrop/src/mod/filesys.mod/files.c
Line 433 in 4703f71
eggdrop/src/mod/modvals.h
Line 75 in 4703f71
eggdrop/src/mod/server.mod/server.h
Lines 83 to 84 in 4703f71
Test cases demonstrating functionality (if applicable):
Bug can be triggert by loading server mod and filesys mod, starting eggdrop and issuing
.files
andget
I didnt analyze the implication any further, but this has crash potential, because currently it would not only set nicklen to a random value (in my test 1447122753) but also trigger a load of misaligned address