-
-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add userhost-in-names capability #1374
Conversation
and fix infinite loop
Current implementation questions:
|
It should still send WHO because we are also interested in account info. |
Still need to add users, not just update hosts (and on updating hosts we might need to call chghost) |
We don't get a WHO response at all (is my understanding)- so we won't get any account info.
Eggdrop gets a JOIN for itself (gotjoin), and sends reset_chan_info. reset_chan_info sets the channel into a CHAN_PENDING status until reset_chan_info calls refresh_who_chan, which sends a WHO #channel to the server. Once the 315 is received, CHAN_PENDING is removed and CHAN_ACTIVE is set. More specifically to the question, it's not ever set right now as a response to NAMES, but after the gotjoin().
From RFC, a 353 (names reply) is sent automatically after a JOIN. ( "If a JOIN is successful, the user is then sent the channel's topic (using RPL_TOPIC) and the list of users who are on the channel (using RPL_NAMREPLY), which must include the user joining") Without Eggdrop sending a NAMES, we're getting a 353 right now "for free". |
Putting this here for probable later discussion:
... because right now I'm debating running NAMES through got352or4 (hello got352or3or4!) |
We're going to pause development on this feature until we can find a server that disables WHO. There are several implementation questions we have that can't be answered by our speculation, we need to see this "in the wild". |
I provided two IRC servers to @vanosg |
b2a7d2d
to
df4d2bf
Compare
c8c438b
to
5a047d7
Compare
4d2cd7e
to
eed19ed
Compare
Fixes: #1368
Fixes #1188
One-line summary:
Add IRCv3 userhost-in-names capability
Additional description (if needed):
This updates channel records with hostmasks received from the userhost-in-names capability, and nothing more. Useful for cases where WHO queries are disabled.\