Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix several net-type bugs #1216

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

michaelortmann
Copy link
Member

@michaelortmann michaelortmann commented Oct 25, 2021

Found by: michaelortmann
Patch by: michaelortmann
Fixes: #1218

One-line summary:
fix several net-type bugs

Additional description (if needed):
net-type must be traced only in irc.mod and from there server.mod is called
in case of error, the net_type and net_type_int variables must not be changed nor Ok, set. must be logged
fatal() must only be called during bot startup

Test cases demonstrating functionality (if applicable):
before:

.set net-type 6
[09:41:11] tcl: builtin dcc call: *dcc:set -HQ 1 net-type 6
[09:41:11] #-HQ# set net-type 6
[09:41:11] * ERROR: NET-TYPE NOT SET.
 Must be one of DALNet, EFnet, freenode, Libera, IRCnet, Quakenet, Rizon, Undernet, Other.

here fatal() lets eggdrop die
after:

.set net-type 6
[12:17:14] tcl: builtin dcc call: *dcc:set -HQ 1 net-type 6
[12:17:14] #-HQ# set net-type 6
Error: can't set "net-type": Must be one of DALNet, EFnet, freenode, Libera, IRCnet, Quakenet, Rizon, Undernet, Other.

@michaelortmann michaelortmann changed the title Fix net-type check/handling, fatal() only during bot startup (WIP) Fix net-type check/handling, fatal() only during bot startup Oct 30, 2021
@michaelortmann michaelortmann changed the title (WIP) Fix net-type check/handling, fatal() only during bot startup (WIP) Fix several net-type issues Oct 30, 2021
@michaelortmann michaelortmann changed the title (WIP) Fix several net-type issues (WIP) Fix several net-type bugs Oct 30, 2021
@michaelortmann michaelortmann changed the title (WIP) Fix several net-type bugs Fix several net-type bugs Oct 30, 2021
@michaelortmann michaelortmann changed the title Fix several net-type bugs (WIP) Fix several net-type bugs Oct 30, 2021
@michaelortmann michaelortmann changed the title (WIP) Fix several net-type bugs Fix several net-type bugs Jul 10, 2024
@vanosg
Copy link
Member

vanosg commented Sep 3, 2024

@thommey comments? Is this still valid?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

net-type bug
2 participants