-
-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance status with reporting maximum number of open files (sockets) #1016
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Can we move this to .status all ? .status is becoming bloated. |
…l parameter to distinguish between status and status all that has more detail and use it to tell maximum number of open files (sockets) only if detail requested
done. this makes this PR even more useful, because now we could easily hide more details, that are currently shown for |
I like where your head is at and appreciate you roughing in code for future work, but I think we should either implement such a change completely, or don't. Looking over how this fits in larger code, I think I'd suggest we just leave it like it is but I'm open to other thoughts or reasons to move. I think anything we move from .status to .status all can just slide right into the existing tell_verbose_status(); the existing format (I think) was created the way it was because some of these functions are called from other sections of code. @thommey thoughts? |
@geo: done, the status boilerplate code is now unaltered. open files/sockets are only shown for |
Found by: michaelortmann
Patch by: michaelortmann
Fixes:
One-line summary:
Additional description (if needed):
While working on dns async code with threads and pipes it came to me, that enhancing .status with reporting maximum number of open files (sockets) could be useful. but i wanted the dns PR to be slim, so i copid the work for .status over to this new PR.
Test cases demonstrating functionality (if applicable):