Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single-quoted strings removed, "module" highlighting fix, new and missing keywords added #3

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

atnbueno
Copy link

@atnbueno atnbueno commented Feb 6, 2018

Single-quoted strings were highlighted, but they result in an error in OpenSCAD.

@atnbueno atnbueno changed the title Removed single-quoted string detection (not supported in OpenSCAD) Single-quoted strings removed (not supported in OpenSCAD) and "module" highlighting fixes Feb 7, 2018
- Fixed **`module` highlighting problems**
- Added **missing and new keywords** (`square`, `polygon`, `circle`, ... and `let`, `each`, `undef`, `assert`, ...)
- Fixed `asun` --> `asin` **typo**
- Marked as **invalid** single-quoted strings (instead of removing them) and deprecated functions (as of version 2008.01.06)
- Differentiates default special variables (`$fn`, `$preview`, ...)
- Differentiates functions and modules
- Differentiates *import* modules and functions (the ones that work with external files) from the others
- More semantical specification of keywords (e.g. not only "operators" but "logical operators", "arithmetic operators", ...)

See [[1]()] and [[2]()] for a visual comparison.

[1]: https://www.mundoplus.tv/atnbueno/openscad_syntax_highlight_vscode_efbenson.png
[2]: https://www.mundoplus.tv/atnbueno/openscad_syntax_highlight_vscode_atnbueno.png
@atnbueno atnbueno changed the title Single-quoted strings removed (not supported in OpenSCAD) and "module" highlighting fixes Single-quoted strings removed, "module" highlighting fix, new and missing keywords added Feb 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant