Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated to match AGIO implementation #5

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

hickmott99
Copy link

Not sure if AGIO-CLI has been updated, but the previous command did not work. The updated command works.

@hickmott99 hickmott99 requested a review from melodell September 20, 2023 20:26
Copy link
Member

@melodell melodell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is weird because I totally had it working with the old command when I uploaded groups the other day! The PK is something like "2035" (some random ID number).

I'm guessing both the old way and the way you added work, depending on if you use the project PK or the course + project number combo. Maybe we should keep them both?

@japplefield
Copy link
Contributor

agio should try to match whatever arg you pass in with the -p flag as follows:

def get_project_smart(project_arg, course_arg, client):
    """Interact with the user to select a project.

    1. If project_arg is a number, look up project by primary key
    2. Use previously defined procedure for smart course selection
    3. If project_arg is None, prompt with list of projects for selected course
    4. If project_arg is a string, try to match project name

    This function provides sanity checks and may exit with an error message.
    """

The example in the README here is from some past term that you may not have access to. My suggestion: add your change here as an additional example instead of a replacement, and add a sentence or two explaining to replace the pk with the pk of the project you're trying to access (you can find it in the autograder URL for the project).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants