Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Closes eecs280staff/p5-ml#183.
@amirkamil noticed that Mermaid diagrams weren't rendering on the P5 spec:
Digging a bit, I found mermaid-js/mermaid#4442, which noted that the root cause was a breaking change in v10 of MermaidJS:
I didn't notice when adding MermaidJS support to Primer Spec, but it turned out that the documentation had let me to always use the latest version of MermaidJS instead of pinning to a specific version — hence, we were exposed to the breaking change :(
In this PR
This commit changes the Primer Spec to always use MermaidJS v9, which is compatible with CJS and exposes the global variable
mermaid
.In future, it would make sense to follow-up how best to upgrade to Mermaid v10. But this works for now.
Validation
Visit the preview URL's "Diagrams" demo. Notice that the Mermaid diagrams now render again.