Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom partitioner to streaming tutorial #78

Merged
merged 4 commits into from
Mar 31, 2024

Conversation

noah-weingarden
Copy link
Contributor

Closes #77. I don't think README.md needs any additions because of this after all.

Copy link

codecov bot commented Mar 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.32%. Comparing base (8e6c1ce) to head (c5a7b7f).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop      #78   +/-   ##
========================================
  Coverage    96.32%   96.32%           
========================================
  Files            4        4           
  Lines          245      245           
========================================
  Hits           236      236           
  Misses           9        9           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@awdeorio awdeorio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after a couple comments

README_Hadoop_Streaming.md Outdated Show resolved Hide resolved
README_Hadoop_Streaming.md Outdated Show resolved Hide resolved
@noah-weingarden noah-weingarden merged commit dca408f into develop Mar 31, 2024
3 checks passed
@noah-weingarden noah-weingarden deleted the docs-custom-partitioner branch March 31, 2024 02:44
@awdeorio
Copy link
Contributor

awdeorio commented Nov 6, 2024

Thank you @noah-weingarden !

@noah-weingarden
Copy link
Contributor Author

No problem! :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add custom partitioning to the Madoop documentation
2 participants