Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flexible num reducers #66

Merged
merged 9 commits into from
Nov 4, 2023
Merged

Flexible num reducers #66

merged 9 commits into from
Nov 4, 2023

Conversation

MattyMay
Copy link
Contributor

@MattyMay MattyMay commented Nov 3, 2023

Add optional -numReduceTasks argument. Closes #55.

@MattyMay MattyMay requested a review from awdeorio November 3, 2023 03:38
@codecov Codecov
Copy link

codecov bot commented Nov 3, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
madoop/__main__.py 93.87% <100.00%> (+0.12%) ⬆️
madoop/mapreduce.py 96.96% <100.00%> (ø)

📢 Thoughts on this report? Let us know!.

@MattyMay MattyMay force-pushed the flexible-num-reducers branch from 99ea992 to cbc3ebd Compare November 3, 2023 03:47
@MattyMay MattyMay requested review from melodell and mbaveja November 3, 2023 23:16
melodell
melodell reviewed Nov 4, 2023
View reviewed changes
Copy link
Member

@melodell melodell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (but I wrote some of this code so wait for another approval lol)

awdeorio
awdeorio approved these changes Nov 4, 2023
View reviewed changes
Copy link
Contributor

@awdeorio awdeorio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@awdeorio awdeorio merged commit 03f260b into develop Nov 4, 2023
3 checks passed
@awdeorio awdeorio deleted the flexible-num-reducers branch November 4, 2023 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melodell melodell melodell left review comments

@awdeorio awdeorio awdeorio approved these changes

@mbaveja mbaveja Awaiting requested review from mbaveja

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make number of reducers flexible
3 participants
@MattyMay @awdeorio @melodell