Skip to content

Commit

Permalink
Revert "chore: updating os version for credentials" (#76)
Browse files Browse the repository at this point in the history
  • Loading branch information
@deborahgu
deborahgu authored Dec 17, 2024
1 parent ac43e34 commit 6963c03
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions dockerfiles/credentials.Dockerfile
View file
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM ubuntu:noble AS base
FROM ubuntu:focal AS base

# System requirements
# - git; Used to pull in particular requirements from github rather than pypi,
Expand Down Expand Up @@ -30,9 +30,9 @@ ENV PATH="$VIRTUAL_ENV/bin:$PATH"
# Create Node env
RUN pip install nodeenv
ENV NODE_ENV=/edx/app/credentials/nodeenvs/credentials
RUN nodeenv $NODE_ENV --node=20.17.0 --prebuilt
RUN nodeenv $NODE_ENV --node=18.17.1 --prebuilt
ENV PATH="$NODE_ENV/bin:$PATH"
RUN npm install -g npm@10.x.x
RUN npm install -g npm@9.x.x

RUN locale-gen en_US.UTF-8
ENV LANG=en_US.UTF-8
Expand Down Expand Up @@ -99,7 +99,7 @@ USER root

RUN curl -L -o credentials/settings/devstack.py https://raw.githubusercontent.com/edx/devstack/master/py_configuration_files/credentials.py

ENV DJANGO_SETTINGS_MODULE=credentials.settings.devstack
ENV DJANGO_SETTINGS_MODULE credentials.settings.devstack

Check warning on line 102 in dockerfiles/credentials.Dockerfile

View workflow job for this annotation

GitHub Actions / build-and-push-image

Legacy key/value format with whitespace separator should not be used 

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format
More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/
RUN pip install -r /edx/app/credentials/credentials/requirements/dev.txt
RUN make pull_translations

Expand Down

0 comments on commit 6963c03

Please sign in to comment.