Skip to content

Commit

Permalink
Merge pull request #64 from edx/iamsobanjaved/fix-analyticsapi-curl
Browse files Browse the repository at this point in the history
fix: move devstack.py curl to apt place
  • Loading branch information
iamsobanjaved authored Nov 25, 2024
2 parents bdf72fd + 02517ba commit 3d7cdb9
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions dockerfiles/edx-analytics-data-api.Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -87,10 +87,6 @@ CMD ["gunicorn" , "-b", "0.0.0.0:8100", "--pythonpath", "/edx/app/analytics_api/

FROM base AS dev

RUN curl -L -o ${ANALYTICS_API_CODE_DIR}/analyticsdataserver/settings/devstack.py https://raw.githubusercontent.com/edx/devstack/master/py_configuration_files/analytics_data_api.py

ENV DJANGO_SETTINGS_MODULE "analyticsdataserver.settings.devstack"

RUN curl -L -o requirements/dev.txt https://raw.githubusercontent.com/edx/edx-analytics-data-api/master/requirements/dev.txt

RUN pip install -r ${ANALYTICS_API_CODE_DIR}/requirements/dev.txt
Expand All @@ -100,6 +96,10 @@ RUN pip install -r ${ANALYTICS_API_CODE_DIR}/requirements/dev.txt
# every time any bit of code is changed.
RUN curl -L https://github.com/edx/edx-analytics-data-api/archive/refs/heads/master.tar.gz | tar -xz --strip-components=1

RUN curl -L -o ${ANALYTICS_API_CODE_DIR}/analyticsdataserver/settings/devstack.py https://raw.githubusercontent.com/edx/devstack/master/py_configuration_files/analytics_data_api.py

ENV DJANGO_SETTINGS_MODULE "analyticsdataserver.settings.devstack"

Check warning on line 101 in dockerfiles/edx-analytics-data-api.Dockerfile

View workflow job for this annotation

GitHub Actions / build-and-push-image

Legacy key/value format with whitespace separator should not be used

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/

Check warning on line 101 in dockerfiles/edx-analytics-data-api.Dockerfile

View workflow job for this annotation

GitHub Actions / build-and-push-image

Legacy key/value format with whitespace separator should not be used

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/

Check warning on line 101 in dockerfiles/edx-analytics-data-api.Dockerfile

View workflow job for this annotation

GitHub Actions / build-and-push-image

Legacy key/value format with whitespace separator should not be used

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/

Check warning on line 101 in dockerfiles/edx-analytics-data-api.Dockerfile

View workflow job for this annotation

GitHub Actions / build-and-push-image

Legacy key/value format with whitespace separator should not be used

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/

# Devstack related step for backwards compatibility
RUN touch /edx/app/${ANALYTICS_API_SERVICE_NAME}/${ANALYTICS_API_SERVICE_NAME}_env

Expand Down

0 comments on commit 3d7cdb9

Please sign in to comment.