feat!: Upgrading to django4.2 #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #266 +/- ##
==========================================
- Coverage 84.68% 84.67% -0.02%
==========================================
Files 61 61
Lines 1208 1207 -1
Branches 130 130
==========================================
- Hits 1023 1022 -1
Misses 160 160
Partials 25 25
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
awais786
commented
Sep 17, 2023
| @@ -57,7 +57,7 @@ defusedxml==0.7.1 | |||
| # python3-openid | |||
| # social-auth-core | |||
| # willow | |||
| django==3.2.21 | |||
| django==4.2.5 | |||
There was a problem hiding this comment.
Version bumped to 4.2
|
We still have MySQL 5.7 on production, so we can't merge this now |
Closed
8 tasks
UsamaSadiq
reviewed
Sep 19, 2023
requirements/doc.txt
Outdated
| @@ -1,5 +1,5 @@ | |||
| # | |||
| # This file is autogenerated by pip-compile with Python 3.8 | |||
| # This file is autogenerated by pip-compile with Python 3.9 | |||
There was a problem hiding this comment.
We should run make upgrade using python 3.8 virtualenv since we haven't updated to Python 3.9 yet.
…2a02664 Python Requirements Update
awais786
commented
Sep 22, 2023
| @@ -118,8 +118,6 @@ | |||
| root('conf', 'locale'), | |||
| ) | |||
|
|
|||
| DEFAULT_HASHING_ALGORITHM = "sha1" | |||
There was a problem hiding this comment.
iamsobanjaved
approved these changes
Sep 22, 2023
alangsto
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrading to django42 and dropped django32 support.
mysql8. Itsdjango42main requirment.Owning team or SRE can confirm mysql8.
Testing instruction