Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: deprecate edx sphinx theme #25

Conversation

huniafatima-arbi
Copy link
Member

@huniafatima-arbi huniafatima-arbi commented Aug 5, 2024

This PR deprecates the edx-sphimx-theme and replaces it with sphinx-book-theme
Issue Link: edx/edx-arch-experiments#339

@saleem-latif
Copy link
Contributor

@huniafatima-arbi Can you please add more details regarding why it is being replaced and if there are potential issues that we should keep an eye out? Also, How different is sphinx-book-theme from edx-sphimx-theme ?

@huniafatima-arbi
Copy link
Member Author

Member

Hi @saleem-latif, I am attaching the issue and rationale behind the edx-theme deprecation. Hope that helps.
DEPR issue link: openedx/public-engineering#200
Regarding your second concern, we are updating the theme for the documentation of the repo. It is well tested. The CI for docs creation is green a well.

@huniafatima-arbi huniafatima-arbi force-pushed the huniafatima/deprecate-edx-sphinx-theme branch from 7f9f6ec to e62d1ae Compare November 6, 2024 11:17
@saleem-latif saleem-latif merged commit ed7493b into edx:master Nov 6, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants