Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: deprecate edx sphinx theme #24

Merged
merged 5 commits into from
Nov 7, 2024

Conversation

huniafatima-arbi
Copy link
Member

@huniafatima-arbi huniafatima-arbi commented Aug 2, 2024

This PR deprecates the edx-sphimx-theme and replaces it with sphinx-book-theme
Issue Link: edx/edx-arch-experiments#339

@huniafatima-arbi huniafatima-arbi linked an issue Aug 2, 2024 that may be closed by this pull request
@huniafatima-arbi huniafatima-arbi requested review from iloveagent57 and removed request for iloveagent57 August 2, 2024 11:02
docs/conf.py Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
requirements/doc.txt Outdated Show resolved Hide resolved
@huniafatima-arbi huniafatima-arbi force-pushed the huniafatima/deprecate-edx-sphinx-theme branch from f5fb4e2 to c3f5cdf Compare October 2, 2024 11:10
Copy link
Member

@UsamaSadiq UsamaSadiq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we upgrade it to use Python 3.12 instead?

@iloveagent57 iloveagent57 dismissed UsamaSadiq’s stale review November 7, 2024 13:56

others have approved, changes made

@iloveagent57 iloveagent57 merged commit 53538ab into main Nov 7, 2024
4 checks passed
@iloveagent57 iloveagent57 deleted the huniafatima/deprecate-edx-sphinx-theme branch November 7, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate edx-sphinx-theme
4 participants