-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: deprecate edx sphinx theme #24
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huniafatima-arbi
requested review from
iloveagent57
and removed request for
iloveagent57
August 2, 2024 11:02
huniafatima-arbi
force-pushed
the
huniafatima/deprecate-edx-sphinx-theme
branch
from
October 2, 2024 11:10
f5fb4e2
to
c3f5cdf
Compare
UsamaSadiq
previously requested changes
Oct 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we upgrade it to use Python 3.12
instead?
iamsobanjaved
approved these changes
Nov 6, 2024
iloveagent57
approved these changes
Nov 6, 2024
iloveagent57
dismissed
UsamaSadiq’s stale review
November 7, 2024 13:56
others have approved, changes made
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR deprecates the
edx-sphimx-theme
and replaces it withsphinx-book-theme
Issue Link: edx/edx-arch-experiments#339