-
Notifications
You must be signed in to change notification settings - Fork 16
Conversation
@itsjeyd I think we will have to skip the changes from open-craft/problem-builder#130. It includes a migration that is going to be removed (not reverted!) in open-craft/problem-builder#131. Since I am not sure when open-craft/problem-builder#131 is getting merged, I think we should open a separate PR that only removes the migration file, and merge it to master before bumping the version number here. I'll prepare that PR now. |
@mtyaka I see, thanks for the info. Ping me when that PR is ready, I can review it. The build for this just failed with "Action failed: bundle install", which seems unrelated to the changes introduced here. Do you know what might be causing that failure by any chance? |
@itsjeyd PR is here: open-craft/problem-builder#133 The build error indicates that bundler was not found on the VM, which is strange. Maybe it was just a random/temporary CircleCI problem. I restarted the build to see. |
@mtyaka I had a look, open-craft/problem-builder#133 looks good to me. Let me know if there's anything I should do to test that PR manually? |
de5813f
to
0074cb1
Compare
@itsjeyd The Problem Builder PR is merged. It looks like bundler is no longer installed by default on CircleCI: https://discuss.circleci.com/t/bundle-command-not-found/3783 It looks like everybody's simply been merging broken builds since August 😕 https://github.com/edx-solutions/edx-platform/pulls?q=is%3Apr+is%3Aclosed |
Rebased from de5813f15e41fb4633d2b2e1c852174fe74a8ff7 (to pull in changes from open-craft/problem-builder#133). |
@mtyaka I updated the commit hash to point to updated master, and updated the PR description to include open-craft/problem-builder#133. And thanks for looking into the bundler issue. Fixing it is out of scope here, then. |
@mtyaka If you're happy with the updates, can I get a thumbs-up from you please? :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
If you have some extra time, it would be interesting to see if adding - gem install bunder
right above the bundle install line fixes the build issues.
- I tested this: Completion block from Implement Completion XBlock open-craft/problem-builder#132
- I read through the code
-
I checked for accessibility issues -
Includes documentation
👍
Normally we wouldn't merge a red build, but we can do so now until we've determined how the current problem will be resolved. I have asked edX. |
Thanks @mtyaka and @bradenmacdonald, merging now. |
This PR pulls in changes from the following constituent PRs (newest first):
cf. OC-2086
Reviewers