Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: exam start time reset #314

Merged
merged 1 commit into from
Sep 3, 2024
Merged

fix: exam start time reset #314

merged 1 commit into from
Sep 3, 2024

Conversation

zacharis278
Copy link
Contributor

JIRA: COSMO-469

Description: Fixes a bug where sending an exam status update with 'started' would always reset the exam start time allowing a user to gain additional time in their exam. This could be triggered in the UI by moving from the ready_to_submit page back to the exam.

Copy link

github-actions bot commented Sep 3, 2024

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  edx_exams/apps/core
  api.py
  edx_exams/apps/core/tests
  test_api.py
Project Total  

This report was generated by python-coverage-comment-action

Copy link
Member

@schenedx schenedx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@varshamenon4 varshamenon4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just one case I wasn't sure about, in comments. Not blocking to merge though.

edx_exams/apps/core/api.py Show resolved Hide resolved
@zacharis278 zacharis278 merged commit 908be84 into main Sep 3, 2024
5 checks passed
@zacharis278 zacharis278 deleted the zhancock/fix-exam-started branch September 3, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants