feat: GET allowances #288
Merged
feat: GET allowances #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
zacharis278
force-pushed
the
zhancock/get-allowances
branch
from
3de7387 to
f45a61d
Compare
zacharis278
commented
Jul 15, 2024
| @@ -109,6 +109,7 @@ class CourseStaffRoleAdmin(admin.ModelAdmin): | |||
| @admin.register(StudentAllowance) | |||
| class StudentAllowanceAdmin(admin.ModelAdmin): | |||
| """ Admin configuration for the Student Allowance model """ | |||
| raw_id_fields = ('user', 'exam') | |||
There was a problem hiding this comment.
updated since the default (a dropdown) is unusable for this on prod/stage
zacharis278
commented
Jul 15, 2024
| course_id=self.course_id, | ||
| ) | ||
|
|
||
| def request_api(self, method, user, course_id): |
There was a problem hiding this comment.
overbuilt in anticipation of post+delete endpoints
schenedx
reviewed
Jul 15, 2024
| response = self.request_api('get', course_staff_user, self.course_id) | ||
| self.assertEqual(response.status_code, 200) | ||
|
|
||
| def test_get_allowances(self): |
There was a problem hiding this comment.
Should we have a DB query count check? I want to ensure this API only call DB once or twice, for even 1000 returned records.
There was a problem hiding this comment.
IMO we only need to check query counts if is there's something more interesting happening in the business logic or model that might hide DB issues. In this case it's a pretty straightforward use of .filter()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: COSMO-368
Description: Adds API to retrieve a list of allowances by course id
The story suggested using generic DRF views for this since there's no business logic. I tried that out but found would introduce a new pattern without making it much simpler really. It would also mess with our class for exception logging