fix: handle dupe user case for mgmt cmd #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varshamenon4
force-pushed
the
varshamenon4/staff-mgmt-command-fix
branch
from
942ae46 to
67b84f8
Compare
rijuma
approved these changes
Apr 19, 2024
zacharis278
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: Link to JIRA ticket
Description: When SRE tried to run the mgmt command in stage, there was an IntegrityError. After investigating, I realized there was a bug/missing edge case. This fix handles the case where there is a duplicate user in the csv itself (previously, was only checking if there was an existing User in the db)
Author concerns: Is this a case I should handle for duplicate CourseStaffRole entries in the CSV? I'm guessing no, because there shouldn't be duplicate entries when pulling from the db.