Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ilee2u/fix prod import django #262

Merged
merged 3 commits into from
Mar 27, 2024
Merged

Ilee2u/fix prod import django #262

merged 3 commits into from
Mar 27, 2024

Conversation

ilee2u
Copy link
Member

@ilee2u ilee2u commented Mar 27, 2024

JIRA: Link to JIRA ticket

Description: Describe in a couple of sentences what this PR adds

Author concerns: List any concerns about this PR - inelegant
solutions, hacks, quick-and-dirty implementations, concerns about
migrations, etc.

Dependencies: dependencies on other outstanding PRs, issues, etc.

Installation instructions: List any non-trivial installation
instructions.

Testing instructions:

  1. Open page A
  2. Do thing B
  3. Expect C to happen
  4. If D happened instead - check failed.

Merge checklist:

  • All reviewers approved
  • CI build is green
  • Changelog record added
  • Documentation updated (not only docstrings)
  • Commits are squashed

Post merge:

  • Delete working branch (if not needed anymore)

@@ -0,0 +1,2 @@
confluent_kafka[avro,schema-registry]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove this file, please?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added it to the gitignore 👍

Copy link
Member

@MichaelRoytman MichaelRoytman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but please remove the private.txt.

@ilee2u ilee2u merged commit a381bae into main Mar 27, 2024
7 checks passed
@ilee2u ilee2u deleted the ilee2u/fix-prod-import-django branch March 27, 2024 17:52
ilee2u added a commit that referenced this pull request Mar 27, 2024
ilee2u added a commit that referenced this pull request Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants