feat: handle instructor permission events #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zacharis278
force-pushed
the
zhancock/course-role-consumer
branch
from
02eccf8 to
096ba43
Compare
alangsto
approved these changes
Feb 27, 2024
| if role not in COURSE_STAFF_ROLES: | ||
| return | ||
|
|
||
| user, created = User.objects.get_or_create( # pylint: disable=unused-variable |
There was a problem hiding this comment.
Instead of adding the pylint disable command, could you just have user, _ = ..., or is there a reason we should have a variable for created?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://2u-internal.atlassian.net/browse/COSMO-151 (2u-internal)
Description: Handles CourseAccessRole events that govern access to the exams dashboard and instructor API actions on exams.
Tested this against my local kafka event bus