Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: performance issue with coursestaffrole admin #233

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

zacharis278
Copy link
Contributor

@zacharis278 zacharis278 commented Dec 21, 2023

The default behavior of this field would be to put every row in the user table into the dropdown. That table is too big to render in a template, and worse, this could potentially lock up the database querying for every record.

@zacharis278 zacharis278 merged commit 5ddae41 into main Dec 21, 2023
8 checks passed
@zacharis278 zacharis278 deleted the zhancock/fix-admin-performance branch December 21, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants