fix: not all usage keys matching #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zacharis278
force-pushed
the
zhancock/content-id-parse
branch
from
3c80e9d to
5fc0c0e
Compare
zacharis278
commented
Dec 14, 2023
| @@ -15,6 +15,6 @@ class Status: | |||
|
|
|||
| COURSE_ID_PATTERN = rf'(?P<course_id>({INTERNAL_COURSE_KEY_PATTERN}|{EXTERNAL_COURSE_KEY_PATTERN}))' | |||
|
|
|||
| CONTENT_ID_PATTERN = r'(?P<content_id>([A-Za-z0-9-_:@\+]+))' | |||
| USAGE_KEY_PATTERN = r'(?P<content_id>(?:i4x://?[^/]+/[^/]+/[^/]+/[^@]+(?:@[^/]+)?)|(?:[^/]+))' | |||
There was a problem hiding this comment.
pulled from edx-platform. I updated the variable to keep the terminology for this matching string consistent.
MichaelRoytman
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where the existing regex would not match the entire content id into the capture group
This would break exams for any course with a
.in the course id (and likely several other cases).