feat: add custom domain param to LTI launch #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zacharis278
changed the title
zacharis278
force-pushed
the
zhancock/custom-domain-param
branch
2 times, most recently
from
e8da2cb to
5f58239
Compare
zacharis278
force-pushed
the
zhancock/custom-domain-param
branch
from
5f58239 to
fde887d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: COSMO-126
Description:
Adds a
custom_urlparameter to the LTI launch. We'll use this to test a few possible approaches to using this url. More details in COSMO-105I've added an entirely new setting for this since that gives us maximum flexibility to play around in stage but I expect the end solution will be a bit more elegant and just use the existing MFE url setting.