-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: send proctoring update emails #201
Conversation
@@ -1,6 +1,7 @@ | |||
# Packages required in a production environment | |||
-r base.txt | |||
|
|||
django-ses |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll compile the new reqs before merging.
{% block status_information %} | ||
{% blocktrans %} | ||
Your proctored exam "{{ exam_name }}" in | ||
<a href="{{ course_url }}">{{ course_url }}</a> was submitted |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These used to have the course name here. For right now we don't have that in the data model.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
edx_exams/apps/core/email.py
Outdated
@@ -0,0 +1,61 @@ | |||
""" | |||
Handles sending emails to users about proctoring status changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#NIT We are going to put all email sending functions into this file, correct? Then I would not be so specific on this comment. This comment is more for the function below, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question about the escalation email, but otherwise looks good
To appeal your proctored exam results, please reach out with any relevant information | ||
about your exam at | ||
<a href="{{contact_url}}"> | ||
{{ contact_url_text }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this email the correct place to escalate to? It's set up per provider, and I feel like it would make more sense for the course team to review this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a really good point. In my head this was the escalation email but that's not true, this email is just tech support for the tool. We don't save an escalation email for LTI but it sounds like we need one. I'm going to open a ticket to discuss adding this end to end.
For now I'm going to update this so this falls back on edx support in absence of a course team email.
JIRA: MST-2087
Description: Send an email when a proctored exam is submitted/verified/rejected
Author concerns: I think this will "just work" since django-ses does all of the interfacing with AWS SES but we'll see.