Modify local Kafka settings. #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
zacharis278
reviewed
Oct 4, 2023
|
@zacharis278 Are you thinking just the URLs are set to |
|
@MichaelRoytman I think just the URLs everything else is seems reusable across dev environments |
This commit removes Django settings from the local settings file, used by the local application server, related to setting up the Kafka implementation of the event bus. This is because the event bus does not work outside of a Docker container. This is because the event bus is run through the devstack networking layer, which is inaccessible by the local application server.
MichaelRoytman
force-pushed
the
michaelroytman/remove-local-kafka-settings
branch
from
c9446a8 to
2e39c7f
Compare
zacharis278
approved these changes
Oct 5, 2023
MichaelRoytman
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: None.
Description:
This commit set Django settings in the local settings file for event bus networking settings to to
None. These settings are used by the local application server. This change is necessary because the event bus does not work outside of a Docker container, because the event bus is run through the devstack networking layer, which is inaccessible by the local application server. Because the local settings file is also used by Tutor, only the networking related settings are set toNone. The remaining settings are left as-is, because they are sensible defaults. Tutor uses can override these settings as need be.Author concerns: None.
Dependencies: None.
Installation instructions: None.
Testing instructions: None.
Merge checklist:
Post merge: