-
Notifications
You must be signed in to change notification settings - Fork 3
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: bulk create course staff mgmt command
- Loading branch information
1 parent
513db6e
commit dafdc1a
Showing
2 changed files
with
32 additions
and
35 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -90,7 +90,7 @@ def test_add_course_staff_with_not_default_batch_size(self): | |
'sam,[email protected],staff,course-v1:edx+test+f20\n'] | ||
with NamedTemporaryFile() as csv: | ||
csv = self._write_test_csv(csv, lines) | ||
with self.assertNumQueries(8): | ||
with self.assertNumQueries(12): | ||
call_command(self.command, f'--csv_path={csv.name}', '--batch_size=1') | ||
|
||
def test_add_course_staff_with_batch_size_larger_than_list(self): | ||
|
@@ -99,7 +99,7 @@ def test_add_course_staff_with_batch_size_larger_than_list(self): | |
'sam,[email protected],staff,course-v1:edx+test+f20\n'] | ||
with NamedTemporaryFile() as csv: | ||
csv = self._write_test_csv(csv, lines) | ||
with self.assertNumQueries(6): | ||
with self.assertNumQueries(11): | ||
call_command(self.command, f'--csv_path={csv.name}', '--batch_size=3') | ||
|
||
def test_add_course_staff_with_batch_size_smaller_than_list(self): | ||
|
@@ -109,7 +109,7 @@ def test_add_course_staff_with_batch_size_smaller_than_list(self): | |
'tam,[email protected],staff,course-v1:edx+test+f20\n'] | ||
with NamedTemporaryFile() as csv: | ||
csv = self._write_test_csv(csv, lines) | ||
with self.assertNumQueries(9): | ||
with self.assertNumQueries(16): | ||
call_command(self.command, f'--csv_path={csv.name}', '--batch_size=2') | ||
|
||
def test_add_course_staff_with_not_default_batch_delay(self): | ||
|
@@ -125,16 +125,16 @@ def test_add_course_staff_with_not_default_batch_delay(self): | |
|
||
def test_num_queries_correct(self): | ||
""" | ||
Assert the number of queries to be 4 + 1 * number of lines: | ||
Assert the number of queries to be 2 + 1 * number of lines: | ||
2 for savepoint/release savepoint | ||
1 to bulk create users, 1 to bulk create course role | ||
1 for each user (to get user) | ||
1 to bulk create course role | ||
4 for each user (to get user, and savepoints) | ||
""" | ||
num_lines = 20 | ||
lines = [f'pam{i},pam{i}@pond.com,staff,course-v1:edx+test+f20\n' for i in range(num_lines)] | ||
with NamedTemporaryFile() as csv: | ||
csv = self._write_test_csv(csv, lines) | ||
with self.assertNumQueries(4 + num_lines): | ||
with self.assertNumQueries(3 + 4 * num_lines): | ||
call_command(self.command, f'--csv_path={csv.name}') | ||
|
||
def test_dupe_user_csv(self): | ||
|