Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: commercetools errors #293

Merged
merged 4 commits into from
Nov 20, 2024
Merged

fix: commercetools errors #293

merged 4 commits into from
Nov 20, 2024

Conversation

abdullahwaheed
Copy link
Contributor

Merge checklist:
Check off if complete or not applicable:

  • Unit tests added/updated

Post-merge:

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 13, 2024 •
edited
Loading

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)		Lines missing
  commerce_coordinator/apps/commercetools
  clients.py
  utils.py
  commerce_coordinator/apps/commercetools/sub_messages
  tasks.py 108
  commerce_coordinator/apps/commercetools/tests
  test_clients.py
Project Total  

This report was generated by python-coverage-comment-action

aht007
aht007 approved these changes Nov 19, 2024
View reviewed changes
Copy link
Member

@aht007 aht007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abdullahwaheed abdullahwaheed merged commit c88a65f into main Nov 20, 2024
8 checks passed
@abdullahwaheed abdullahwaheed deleted the abdullahwaheed/SONIC-743 branch November 20, 2024 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aht007 aht007 aht007 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abdullahwaheed @aht007