refactor: make course mode logic dynamic #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahtesham-quraish
force-pushed
the
ahtesham/course-mode/SONIC-732
branch
4 times, most recently
from
0c2dddc to
b2c4114
Compare
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||||||||||||||
shafqatfarhan
requested review from
aht007,
shafqatfarhan,
syedsajjadkazmii and
abdullahwaheed
shafqatfarhan
previously requested changes
Nov 8, 2024
commerce_coordinator/apps/commercetools/catalog_info/edx_utils.py
Outdated
Show resolved
Hide resolved
commerce_coordinator/apps/commercetools/catalog_info/edx_utils.py
Outdated
Show resolved
Hide resolved
syedsajjadkazmii
approved these changes
Nov 12, 2024
commerce_coordinator/apps/commercetools/catalog_info/edx_utils.py
Outdated
Show resolved
Hide resolved
ahtesham-quraish
force-pushed
the
ahtesham/course-mode/SONIC-732
branch
6 times, most recently
from
e149db9 to
70a7caa
Compare
aht007
reviewed
Nov 14, 2024
commerce_coordinator/apps/commercetools/catalog_info/edx_utils.py
Outdated
Show resolved
Hide resolved
commerce_coordinator/apps/commercetools/catalog_info/edx_utils.py
Outdated
Show resolved
Hide resolved
commerce_coordinator/apps/commercetools/tests/raw_ct_order.json
Outdated
Show resolved
Hide resolved
ahtesham-quraish
force-pushed
the
ahtesham/course-mode/SONIC-732
branch
6 times, most recently
from
b450444 to
48d88f3
Compare
aht007
approved these changes
Nov 14, 2024
aht007
dismissed
shafqatfarhan’s stale review
Changes have been incorporated, Shafqat is on leaves
added 2 commits
November 14, 2024 13:20
Description: Make Fulfillment logic dynamic to support all course modes SONIC-732
Description: Address comments SONIC-732
added 2 commits
November 14, 2024 13:20
Description Create util for get_line_item_attribute SONIC
Description: Move the get order util to util folder SONIC
ahtesham-quraish
force-pushed
the
ahtesham/course-mode/SONIC-732
branch
from
48d88f3 to
fa24efc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Make Fulfillment logic dynamic to support all course modes
SONIC-732
Merge checklist:
Check off if complete or not applicable:
Post-merge: