Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: Python 3.12 Upgrade #284

Merged
merged 8 commits into from
Dec 9, 2024
Merged

feat!: Python 3.12 Upgrade #284

merged 8 commits into from
Dec 9, 2024

Conversation

huniafatima-arbi
Copy link
Member

@huniafatima-arbi huniafatima-arbi commented Oct 30, 2024 •
edited
Loading

Merge checklist:
Check off if complete or not applicable:

  • Documentation updated (not only docstrings)
  • Fixup commits are squashed away
  • Unit tests added/updated
  • Manual testing instructions provided
  • Noted any: Concerns, dependencies, migration issues, deadlines, tickets

Post-merge:

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 30, 2024 •
edited
Loading

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)		Lines missing
  commerce_coordinator/apps/commercetools/catalog_info
  constants.py
  commerce_coordinator/apps/commercetools/tests
  conftest.py
  commerce_coordinator/apps/core
  constants.py
  commerce_coordinator/apps/ecommerce
  data.py
Project Total  

This report was generated by python-coverage-comment-action

@huniafatima-arbi huniafatima-arbi force-pushed the huniafatima/python-and-django-update branch from 4ef89c3 to 6e9dd93 Compare October 30, 2024 16:39
@huniafatima-arbi huniafatima-arbi mentioned this pull request Oct 31, 2024
Closed
iamsobanjaved
iamsobanjaved approved these changes Nov 13, 2024
View reviewed changes
Copy link
Member

@iamsobanjaved iamsobanjaved left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

attiyaIshaque
attiyaIshaque approved these changes Nov 14, 2024
View reviewed changes
Copy link
Member

@attiyaIshaque attiyaIshaque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. 👍 Please rebase your branch with the latest change.

@attiyaIshaque
Copy link
Member

Please resolve the conflicts.

@huniafatima-arbi
Copy link
Member Author

Please resolve the conflicts.

@attiyaIshaque
Rebased the PR and resolved conflicts. Please proceed with the merge

aht007
aht007 approved these changes Dec 3, 2024
View reviewed changes
Copy link
Member

@aht007 aht007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@UsamaSadiq UsamaSadiq changed the title chore: upgrade python version feat!: Python 3.12 Upgrade Dec 3, 2024
@UsamaSadiq UsamaSadiq enabled auto-merge (squash) December 9, 2024 11:24
@UsamaSadiq UsamaSadiq merged commit b1e03fb into main Dec 9, 2024
8 checks passed
@UsamaSadiq UsamaSadiq deleted the huniafatima/python-and-django-update branch December 9, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aht007 aht007 aht007 approved these changes

@iamsobanjaved iamsobanjaved iamsobanjaved approved these changes

@attiyaIshaque attiyaIshaque Awaiting requested review from attiyaIshaque

Assignees
No one assigned
Labels
None yet
Projects
Arbi-BOM
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@huniafatima-arbi @attiyaIshaque @iamsobanjaved @aht007 @UsamaSadiq