Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [SONIC-650] Added PayPal custom attributes management command #278

Merged
merged 4 commits into from
Oct 18, 2024

Conversation

shafqatfarhan
Copy link
Member

Merge checklist:
Check off if complete or not applicable:

  • Documentation updated (not only docstrings)
  • Fixup commits are squashed away
  • Unit tests added/updated
  • Manual testing instructions provided
  • Noted any: Concerns, dependencies, migration issues, deadlines, tickets

Post-merge:

Copy link

github-actions bot commented Oct 11, 2024

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  commerce_coordinator/apps/commercetools/catalog_info
  constants.py
  foundational_types.py
Project Total  

This report was generated by python-coverage-comment-action

Copy link
Member

@aht007 aht007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some improvement comments. LGTM 🚀

@shafqatfarhan shafqatfarhan enabled auto-merge (rebase) October 18, 2024 10:02
@shafqatfarhan shafqatfarhan merged commit 30d452b into main Oct 18, 2024
9 checks passed
@shafqatfarhan shafqatfarhan deleted the shafqat/SONIC-650 branch October 18, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants