Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.rst with set up of CT #274

Merged
merged 11 commits into from
Oct 2, 2024
Merged

Conversation

NoyanAziz
Copy link
Contributor

@NoyanAziz NoyanAziz commented Sep 25, 2024

Merge checklist:
Check off if complete or not applicable:

  • Documentation updated (not only docstrings)
  • Fixup commits are squashed away
  • Unit tests added/updated
  • Manual testing instructions provided
  • Noted any: Concerns, dependencies, migration issues, deadlines, tickets

Post-merge:

Copy link

Coverage report

This PR does not seem to contain any modification to coverable code.

Copy link
Member

@aht007 aht007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some improvement comments, overall LGTM

README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
@aht007
Copy link
Member

aht007 commented Sep 26, 2024

Please also sqush the commits locally and push again with correct commit name and type so that commitlint passes

README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
@NoyanAziz NoyanAziz merged commit e18409a into main Oct 2, 2024
8 of 9 checks passed
@NoyanAziz NoyanAziz deleted the naziz1/SONIC-723/update-readme branch October 2, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants