Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: deprecate edx sphinx theme #259

Merged
merged 2 commits into from
Nov 21, 2024

Conversation

huniafatima-arbi
Copy link
Member

@huniafatima-arbi huniafatima-arbi commented Aug 8, 2024

This PR deprecates the edx-sphimx-theme and replaces it with sphinx-book-theme
Issue Link: edx/edx-arch-experiments#339

Copy link

github-actions bot commented Aug 8, 2024

Coverage report

This PR does not seem to contain any modification to coverable code.

@huniafatima-arbi huniafatima-arbi enabled auto-merge (squash) November 4, 2024 08:24
Copy link
Member

@attiyaIshaque attiyaIshaque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. 👍 Please rebase your branch with the latest change.

@dianakhuang dianakhuang force-pushed the huniafatima/deprecate-edx-sphinx-theme branch from a660f61 to 47d5556 Compare November 21, 2024 14:06
@dianakhuang dianakhuang merged commit d33974a into main Nov 21, 2024
8 checks passed
@dianakhuang dianakhuang deleted the huniafatima/deprecate-edx-sphinx-theme branch November 21, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants