Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added missing tests #255

Merged
merged 2 commits into from
Jul 22, 2024
Merged

feat: added missing tests #255

merged 2 commits into from
Jul 22, 2024

Conversation

JadeyOlivier
Copy link
Member

Description: Added missing tests from #182 previously covered by pragma no cover.
JIRA: SONIC-449

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 18, 2024 •
edited
Loading

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)		Lines missing
  commerce_coordinator/apps/commercetools
  clients.py
  commerce_coordinator/apps/commercetools/tests
  conftest.py
  test_clients.py
  commerce_coordinator/apps/lms
  tasks.py
  commerce_coordinator/apps/lms/tests
  test_tasks.py
Project Total  

This report was generated by python-coverage-comment-action

@bdizha bdizha self-requested a review July 18, 2024 14:27
grmartin
grmartin approved these changes Jul 22, 2024
View reviewed changes
Copy link
Member

@grmartin grmartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its interesting this didnt change coverage. lets monitor over the next few weeks and see if coverage is working right... LGTM, Merge it..

@JadeyOlivier JadeyOlivier merged commit 22a0017 into main Jul 22, 2024
9 checks passed
@JadeyOlivier JadeyOlivier deleted the jolivier/SONIC-449/Tests-For-SONIC-270 branch July 22, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdizha bdizha bdizha approved these changes

@grmartin grmartin grmartin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JadeyOlivier @grmartin @bdizha