[BD-46] fix: do not override SearchField styles
#77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, @viktorrusakov! When this pull request is ready, tag your edX technical lead. Thanks for your pull request, but this repo does not accept outside contributions unless they are under contract. If you think this is an error, please contact @nedbat. |
10 tasks
jsnwesson
approved these changes
Jun 4, 2024
adamstankiewicz
approved these changes
Jun 4, 2024
|
🎉 This PR is included in version 2.1.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR together with openedx/paragon#2675 fix openedx/paragon#2650 by removing old and unnecessarry overrides of
SearchFieldcomponent. This waySearchFieldwill inherit button styles from Paragon'sButtoncomponent which will solve design issues with the component.Note that consuming MFEs will need to upgrade versions of brand-edx.org package and Paragon together in one commit in order for the fix to work.