Ed binop #86
Merged
Ed binop #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| | Ast.Concat -> | ||
| Cast.Call(Cast.Function("nh_support","concat"),[castx_of_sastx lexpr; castx_of_sastx rexpr]) | ||
| | Ast.Chord -> failwith "Internal error: binop chord should have been converted to Call NhFunction in ast2sast" | ||
| | Ast.Octave -> failwith "Internal error: binop octave should have been converted to Call NhFunction in ast2sast" |
There was a problem hiding this comment.
Potentially an unpopular opinion, but i think we should make a Sast binop that excludes Zip, Chord, and Octave. Reasoning:
- These runtime failwiths wil become compile time errors
- Conceptually more correct -- the operators
: @ ,are just syntactic sugar for calling stdlib functions. So they should only exist in the ast, not the sast.
There was a problem hiding this comment.
(And the same for uniop's flat and sharp)
There was a problem hiding this comment.
I agree, but be aware that you are also giving me arthritis of the fingers.
|
fix 'n 🚤 |
| ) | ||
| else throw "Cannot concat tracks with different key or time signature" | ||
| } | ||
|
|
There was a problem hiding this comment.
this crashes the parser.
could you comment it out, and change tabs to spaces?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.