Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add example for AccountSettingsRenderStarted filter #1

Merged
merged 4 commits into from
Mar 6, 2023
Merged

feat: add example for AccountSettingsRenderStarted filter #1

merged 4 commits into from
Mar 6, 2023

Conversation

Henrrypg
Copy link
Contributor

@Henrrypg Henrrypg commented Dec 5, 2022

This PR is to add an example for AccountSettingsRenderStarted filter.

This filter's PR is open in: openedx/openedx-filters#46

The hook in edx-platform is open in: openedx/edx-platform#31295

"""
Pipeline step that stop access to account settings page.
"""
raise CourseAboutRenderStarted.RedirectToPage(
Copy link
Collaborator

@mariajgrimaldi mariajgrimaldi Dec 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why CourseAboutRenderStarted if the filter is called StopAccountSettingsRender?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's my bad, i just fixed it

@Henrrypg
Copy link
Contributor Author

Henrrypg commented Mar 1, 2023

Hello @mariajgrimaldi, Can you look at this changes?

@mariajgrimaldi mariajgrimaldi merged commit 5e6f82b into eduNEXT:master Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants