-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: improve the documentation #210
Conversation
0a27346
to
a29fb7c
Compare
Hi @dcoa, Thank you for the detailed explanation in the PR description regarding the removal of setting configurations for previous Open edX releases. Your points about simplification, relevance, maintenance, and accuracy are well noted. However, I have a few thoughts:
I think it's a good idea to include this information in the release notes from now on. Maybe we could keep the currently listed settings configurations in a document on RTD and just provide a link to it in this README so users can check it if needed? |
Hi, I have been thinking about just adding the link to the tag/documentation should be enough: e.g: https://github.com/eduNEXT/eox-tenant/blob/v6.2.0/README.rst, at least for releases that are not compatible with the current version. Because if the table show that nutmeg is compatible with versions greater than or equal to 6.2, it means the latest version 11.7.0 is compatible also. Its assumed that a version is compatible by default if the user doesn't have to change any setting, if the user has to do something, we should add it to our docs. However, remember that we have "contract" to support the previous release and current release, if a release is 2 version before the current, we could try but is not mandatory. |
To clarify, I will use “version” to talk about eox-tenant and release to refer to Open edX. I'm not 100% sure if I caught your concerns but those are my thoughts: @Alec4r, the contract is still maintained, this repository is a good example of it, the changes for Maple, which is the oldest release supported for 11.x, are listed. Nutmeg, Palm, and Olive are not listed because they use the same configuration as Quince does. I was thinking of the major release (for the settings list), and the paragraph description does not explain that, sorry for that.
@magajh, I'm not against this idea, even at some point we have to do that because of the length that section would have in the future. The compatibility notes table should exist as it is because that gives us an idea of which version to install for each Open edX release, we agree about that. However, from my point of view ,the usage section should describe the information for the eox-tenant version that is displayed. If the user wants to use version 6.x, they can visit that tag and the readme gives the corresponding settings. Let's use Django documentation as an example, when you open it, the latest release (5.0) is displayed if you are using a previous one, you should select the version, that changes the documentation. (I think is the same but inside GitHub). Of course, the most important here is to have documentation useful for anyone and you have a better understanding of what is necessary, I'm open to making any relevant changes. 😁 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dcoa @Alec4r thank you both for your comments!
@dcoa I agree that this README is good as it is. I don't think we need to make any more changes, except for one suggestion in the section where we explain what happens if the version the user wants is not listed, for better understanding.
Please ping me if you need my approval again.
Co-authored-by: Bryann Valderrama <[email protected]>
Co-authored-by: Bryann Valderrama <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This PR improves the repository documentation for a better understanding of the eox-tenant plugin.
For the plugin description
Proposal
➡️ Maintain the settings configuration for the current release.
Also, the packages management like (pypi or npm - use the readme and the latest release to explain the documentation) if you want to install another version you should select it and that will show you the relevant information for that tag (readme for that version). That behavior is another motivation for this change, showing the information relevant to the version that the user wants to use.
Additional information
JIRA