Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: add compatibility with Quince release #101

Merged
merged 4 commits into from
Feb 13, 2024
Merged

Conversation

bra-i-am
Copy link
Contributor

@bra-i-am bra-i-am commented Feb 7, 2024

Description

This PR adds support for the Open edx Quince release. Adds issue templates.

Testing instructions

  1. Create an environment with qUINCE release, you can use Tutor or TVM
  2. Clone this repo in a folder src in your Tutor root, git checkout the clone to this branch, and mount the clone into the container using tutor mounts add lms:./path/to/local/eox-manage:/openedx/extra-deps/eox-manage command (more information) or using the docker-compose.override.yml
  3. Install the plugin eox-tagging inside the container by doing:
    • Go inside the container executing tutor dev/local exec lms bash
    • Install the plugin with pip install ../extra-deps/eox-manage according to the place where was stored in point 2
    • Run migrations inside the container with python manage.py lms makemigrations && python manage.py lms migrate
  4. Restart the containers
  5. Go to the test cases file to know pre-requirements and configurations your need to set for testing eox-tagging

Aditional information

JIRA ISSUE DS-788

* fix: delete deprecated pylint rules
* fix: use pylint messages control
* fix: ignore migrations from quality tests
* fix: solve deprecated methods & apply linter corrections
@github-actions github-actions bot added the size/m label Feb 7, 2024
@Alec4r Alec4r requested review from dcoa and MaferMazu February 7, 2024 23:04
@bra-i-am bra-i-am changed the title Bc/add quince support perf: add compatibility with Quince release Feb 7, 2024
@bra-i-am bra-i-am marked this pull request as ready for review February 7, 2024 23:18
@bra-i-am bra-i-am requested a review from a team February 7, 2024 23:19
Copy link
Contributor

@MaferMazu MaferMazu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @bra-i-am. 🔥
It looks very good to me. You updated the requirements and documentation, and the test cases worked as expected. I will only suggest the new line in labeler.yml.

@bra-i-am bra-i-am merged commit 2fddeab into master Feb 13, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants