Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IDMP-744 - Investigate simplifying potential circularities in the packaging / container specification part of the ontology #642

Merged
merged 6 commits into from
Nov 21, 2024

Conversation

ElisaKendall
Copy link
Contributor

@ElisaKendall ElisaKendall commented Oct 17, 2024

Description:

  1. Simplified the packaging model by eliminating container constituency and revising the definition of medicinal product container (of which package item is a subclass) accordingly, as well as a redundant restriction on package item
  2. Revised the Amlodipine example to reflect these changes
  3. Revised the Qlaira example to reflect these changes

…nstituency and revising the definition of medicinal product container (of which package item is a subclass) accordingly, as well as a redundant restriction on package item; revised the Amlodipine example to reflect these changes

Signed-off-by: Elisa Kendall <[email protected]>
…ge to eliminate constituency, for the 1x28 tablet case

Signed-off-by: Elisa Kendall <[email protected]>
…roduct from being something that a medicinal product container can include (a pharmaceutical product must be part of a manufactured item or medicinal product to be included in a container)

Signed-off-by: Elisa Kendall <[email protected]>
…the container constituency

Signed-off-by: Elisa Kendall <[email protected]>
@ElisaKendall ElisaKendall changed the title IDMP-744 - Investigate simplifying potential circularities in the packaging / container specification part of the ontology (WIP) IDMP-744 - Investigate simplifying potential circularities in the packaging / container specification part of the ontology Oct 22, 2024
@tw-osthus
Copy link
Contributor

Adding package item -has constituent -> package constituent makes package item a constituency by inference. This is ok, because package item is a specification/definition of a physical item based largely on how it is composed. So from that side I approve and like this change.

However I do not like the current definition (coming from the idmp spec) of package item, a subclass of material specification , which if can likely be misunderstood as a physical thing and if that were the case it would be inconsistent. An explanatory note is needed, if we want to keep the definition.

…t is a specification rather than an actual physical package item

Signed-off-by: Elisa Kendall <[email protected]>
@ElisaKendall
Copy link
Contributor Author

Adding package item -has constituent -> package constituent makes package item a constituency by inference. This is ok, because package item is a specification/definition of a physical item based largely on how it is composed. So from that side I approve and like this change.

However I do not like the current definition (coming from the idmp spec) of package item, a subclass of material specification , which if can likely be misunderstood as a physical thing and if that were the case it would be inconsistent. An explanatory note is needed, if we want to keep the definition.

Fixed

@mereolog mereolog merged commit 0a64d96 into master Nov 21, 2024
7 checks passed
@mereolog mereolog deleted the IDMP-744 branch November 21, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants