Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changing click to double click. fix typos. cleanup #14

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

changing click to double click. fix typos. cleanup #14

wants to merge 4 commits into from

Conversation

jameelmoses
Copy link

  • Code cleanup
  • Fixed typos in JS and CSS for ACF versions <= 5.6
  • Open modal when layout field is double clicked instead of a single click to prevent opening on re-order

@jameelmoses
Copy link
Author

@edirpedro any chance of getting this reviewed/merged quickly so I can use composer to install the package?

@edirpedro
Copy link
Owner

The double click doesn't sound a good idea to use to open the modal because anything on a website uses double click, this is an option for O.S. only and users won't recognize this option without you teach them.

I tested the drag and drop and I didn't find any trouble on it, I reordered with any issues with a mouse or trackpad. I had a mouse before with problems with the click and this sometimes caused this effect to loose when trying to drag an object. Could that be your case?

@jameelmoses
Copy link
Author

@edirpedro the issue was occurring on a MacBook Pro's trackpad on release when dragging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants