e2e: also run log download on e2e failure (#1038)

edgelesssys · Nov 28, 2024 · 9a3799c · 9a3799c
1 parent f5a372c
commit 9a3799c
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/.github/workflows/e2e.yml b/.github/workflows/e2e.yml
@@ -73,12 +73,16 @@ jobs:
           just coordinator initializer port-forwarder openssl cryptsetup service-mesh-proxy node-installer ${{ inputs.platform }}
       - name: E2E Test
         run: |
+          nix build .#scripts.get-logs
           nix run .#scripts.get-logs start workspace/e2e.namespace &
           nix shell -L .#contrast.e2e --command ${{ inputs.test-name }}.test -test.v \
             --image-replacements workspace/just.containerlookup \
             --namespace-file workspace/e2e.namespace \
             --platform ${{ inputs.platform }} \
             --skip-undeploy="${{ inputs.skip-undeploy && 'true' || 'false' }}"
+      - name: Download logs
+        if: always()
+        run: |
           nix run .#scripts.get-logs download workspace/e2e.namespace
       - name: Upload logs
         if: always()

diff --git a/.github/workflows/e2e_aks_runtime.yml b/.github/workflows/e2e_aks_runtime.yml
@@ -80,13 +80,17 @@ jobs:
           az extension add --name confcom
       - name: E2E test
         run: |
+          nix build .#scripts.get-logs
           nix run .#scripts.get-logs start workspace/e2e.namespace &
           nix build .#contrast.e2e
           ./result/bin/aks-runtime.test -test.v \
             --image-replacements workspace/just.containerlookup \
             --namespace-file workspace/e2e.namespace \
             --platform AKS-CLH-SNP \
             --skip-undeploy="false"
+      - name: Download logs
+        if: always()
+        run: |
           nix run .#scripts.get-logs download workspace/e2e.namespace
       - name: Upload logs
         if: always()