-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add FreeBSD support #53
base: master
Are you sure you want to change the base?
Conversation
Thanks for your PR! I'm excited about adding new OSes. I am going to try and get this merged first, so bear with me: #38 I may need you to rebase after that. |
Looks like you didn't modify the files that the tests are complaining about. I need to get some things updated so the test pass. I wouldn't worry about it at this point. |
Sure thing!
👍 |
@edestecd Do you still plan to merge this PR? |
This looks good to me. Would you mind rebasing? Sorry for the delay. |
47a53b2
to
4ef4268
Compare
@edestecd Rebased and ready for merge :) |
4ef4268
to
29035a5
Compare
@edestecd Rebased (again) and fixed the merge conflict, please merge :) |
Hi @edestecd, now that version 2.0 is out, would you please consider to merge this PR? Thanks! :) |
ping @edestecd :) |
metadata.json
accordingly