Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add raw upload #191

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from
Draft

Conversation

edeckers
Copy link
Owner

@edeckers edeckers commented Jan 17, 2022

Originally requested in: #170

Updates

2021-06-01

  • Considering building this feature off of Add raw http body request #141, since they seem to overlap a lot
  • DownloadManager on Android does not support another HTTP method than GET and does not accept a body, so the new interface has to account for this

Todo

  • Apply interface changes to facilitate raw body
  • Warn users of future major release uploadBlob-behavior change due to misnomer through deprecation annotation
  • Warn users of future major release uploadBlob-behavior change due to misnomer through README warning
  • Add implementation for raw body requests
  • Add Android tests
  • Add iOS tests
  • Add TypeScript tests
  • Add documentation to README.md
  • Clean-up added and modified code

@edeckers edeckers added enhancement New feature or request iOS Android labels Jan 17, 2022
@edeckers edeckers added this to the 3.0.5 milestone Jan 17, 2022
@edeckers edeckers self-assigned this Jan 17, 2022
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@edeckers edeckers linked an issue Jan 18, 2022 that may be closed by this pull request
@github-actions
Copy link
Contributor

TypeScript Test Report

  1 files  ±0    1 suites  ±0   2s ⏱️ ±0s
35 tests ±0  35 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit a308656. ± Comparison against base commit 29ccba9.

@github-actions
Copy link
Contributor

Android Unit Test Report

  1 files  ±0    1 suites  ±0   12s ⏱️ +3s
19 tests ±0  19 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit a308656. ± Comparison against base commit 29ccba9.

@github-actions
Copy link
Contributor

Android Instrumented Test Report

0 files  ±0  0 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit a308656. ± Comparison against base commit 29ccba9.

@github-actions
Copy link
Contributor

iOS Test Report

  1 files  ±0    1 suites  ±0   9s ⏱️ -1s
15 tests ±0  15 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit a308656. ± Comparison against base commit 29ccba9.

@edeckers edeckers force-pushed the develop branch 2 times, most recently from 42e6fe2 to 381c372 Compare March 28, 2022 21:29
@iampato
Copy link

iampato commented Jul 15, 2023

Any updates?

@edeckers
Copy link
Owner Author

Hi @iampato, no updates at this time. I'm still planning on picking up the open issues eventually, but large chunks of work don't fit my current schedule.

I do accept and appreciate PR's, so if you feel up to it I would gladly make some time for a little sparring and reviewing the changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android enhancement New feature or request iOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to pass body to fetchBlob
2 participants